morrySnow commented on code in PR #46288:
URL: https://github.com/apache/doris/pull/46288#discussion_r1900630431


##########
fe/fe-core/src/main/java/org/apache/doris/planner/SchemaScanNode.java:
##########
@@ -166,4 +169,35 @@ protected void createScanRangeLocations() throws 
UserException {
     public int getNumInstances() {
         return 1;
     }
+
+    @Override
+    public String getNodeExplainString(String prefix, TExplainLevel 
detailLevel) {
+        StringBuilder output = new StringBuilder();
+        output.append(prefix).append("TABLE: 
").append(getSchemaDb()).append(".").append(getTableName());
+        output.append("\n");
+        if (sortColumn != null) {
+            output.append(prefix).append("SORT COLUMN: 
").append(sortColumn).append("\n");
+        }
+        if (useTopnFilter()) {
+            String topnFilterSources = String.join(",",
+                    topnFilterSortNodes.stream()
+                            .map(node -> node.getId().asInt() + 
"").collect(Collectors.toList()));
+            output.append(prefix).append("TOPN 
OPT:").append(topnFilterSources).append("\n");
+        }

Review Comment:
   remove this



##########
fe/fe-core/src/main/java/org/apache/doris/planner/SchemaScanNode.java:
##########
@@ -166,4 +169,35 @@ protected void createScanRangeLocations() throws 
UserException {
     public int getNumInstances() {
         return 1;
     }
+
+    @Override
+    public String getNodeExplainString(String prefix, TExplainLevel 
detailLevel) {
+        StringBuilder output = new StringBuilder();
+        output.append(prefix).append("TABLE: 
").append(getSchemaDb()).append(".").append(getTableName());
+        output.append("\n");
+        if (sortColumn != null) {
+            output.append(prefix).append("SORT COLUMN: 
").append(sortColumn).append("\n");
+        }

Review Comment:
   remove this



##########
fe/fe-core/src/main/java/org/apache/doris/planner/SchemaScanNode.java:
##########
@@ -166,4 +169,35 @@ protected void createScanRangeLocations() throws 
UserException {
     public int getNumInstances() {
         return 1;
     }
+
+    @Override
+    public String getNodeExplainString(String prefix, TExplainLevel 
detailLevel) {
+        StringBuilder output = new StringBuilder();
+        output.append(prefix).append("TABLE: 
").append(getSchemaDb()).append(".").append(getTableName());
+        output.append("\n");
+        if (sortColumn != null) {
+            output.append(prefix).append("SORT COLUMN: 
").append(sortColumn).append("\n");
+        }
+        if (useTopnFilter()) {
+            String topnFilterSources = String.join(",",
+                    topnFilterSortNodes.stream()
+                            .map(node -> node.getId().asInt() + 
"").collect(Collectors.toList()));
+            output.append(prefix).append("TOPN 
OPT:").append(topnFilterSources).append("\n");
+        }
+        if (!conjuncts.isEmpty()) {
+            Expr expr = convertConjunctsToAndCompoundPredicate(conjuncts);
+            output.append(prefix).append("PREDICATES: 
").append(expr.toSql()).append("\n");
+        }
+        if (!runtimeFilters.isEmpty()) {
+            output.append(prefix).append("runtime filters: ");
+            output.append(getRuntimeFilterExplainString(false));
+        }
+        output.append(prefix).append(String.format("cardinality=%s", 
cardinality))
+                .append(String.format(", avgRowSize=%s", 
avgRowSize)).append(String.format(", numNodes=%s", numNodes));
+        output.append("\n");
+        if (pushDownAggNoGroupingOp != null) {
+            
output.append(prefix).append("pushAggOp=").append(pushDownAggNoGroupingOp).append("\n");
+        }

Review Comment:
   remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to