feiniaofeiafei commented on code in PR #45928:
URL: https://github.com/apache/doris/pull/45928#discussion_r1900687299
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/WeeksAdd.java:
##########
@@ -41,7 +42,7 @@
*/
public class WeeksAdd extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature,
- ComputeSignatureForDateArithmetic, PropagateNullableOnDateLikeV2Args {
+ ComputeSignatureForDateArithmetic, PropagateNullableOnDateLikeV2Args,
DateAddSubMonotonic {
Review Comment:
If the first child is a constant, it will not affect the calculation of
partition pruning. Consider the date_trunc('2024-01-01', 'day') function. If
constant folding is turned on, the calculation logic of partition pruning will
not be entered; if constant folding is turned off, the range returned by
'2024-01-01' to the upper-level expression is empty. In this case, the range
calculation will not be performed on this function, and the wrong partition
pruning result will not be calculated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
