englefly commented on code in PR #46171:
URL: https://github.com/apache/doris/pull/46171#discussion_r1901408599
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RecomputeOutputProcessor.java:
##########
@@ -22,13 +22,14 @@
import org.apache.doris.nereids.trees.plans.physical.AbstractPhysicalPlan;
/**
- * merge consecutive projects
+ * recompute output in logical properties
+ * after join reorder, plan output slot order is changed, recompute them.
*/
-public class RecomputeLogicalPropertiesProcessor extends PlanPostProcessor {
+public class RecomputeOutputProcessor extends PlanPostProcessor {
Review Comment:
LogicalProperties contains 2 parts: output and dataTrait
the purpose of this rule is to reset output, not dataTrait.
when we implement this rule, dataTrait is not a part of logicalProperties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
