englefly opened a new pull request, #46468:
URL: https://github.com/apache/doris/pull/46468
### What problem does this PR solve?
previous verion has follow drawbacks
1. inferred some in-predicates, which cannot be pushed down to storage layer
2. it is easy to lead dead loop, because other expression rewrite rule may
remove its flag in expression's mutableState
in order to solve above issues, we implemented a new version
first, it is a plan node level rule to avoid to be applied to the same
expression repeatedly
second, we define replace mode and extract mode. if in replace mode, the
original expression should be equivalent to the inferred in-pred, which is used
for all plan node's expressions except filter.
for example, orig = "(a=1 and b=1) or (a=2 and c=2)" is equivalent to "a in
(1, 2) and (a=1 and b=1) or (a=2 and c=2)".
orig is a filter condition, "a in (1, 2)" can be pushed down to storage
layer, and this infer is useful. But if this is orig is an other join
condition, this inferrence is useless. So in extract mode, "a in (1, 2)" is
inferred, but in replace mode, it is not.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
