yixiutt commented on code in PR #10153:
URL: https://github.com/apache/incubator-doris/pull/10153#discussion_r897769114
##########
be/src/olap/tablet.cpp:
##########
@@ -713,21 +713,6 @@ bool Tablet::can_do_compaction(size_t path_hash,
CompactionType compaction_type)
return false;
}
- if (tablet_state() == TABLET_RUNNING) {
- // if tablet state is running, we need to check if it has consistent
versions.
- // tablet in other state such as TABLET_NOTREADY may not have complete
versions.
- std::shared_lock rdlock(_meta_lock);
- const RowsetSharedPtr lastest_delta = rowset_with_max_version();
Review Comment:
in concurrent load, this check is not correct cause some publish task is
flying, remove this check because we have consective version check in pick
input rowset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
