morningman commented on code in PR #46026:
URL: https://github.com/apache/doris/pull/46026#discussion_r1914196292
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java:
##########
@@ -379,10 +378,11 @@ private void testJdbcConnection() throws DdlException {
private void testFeToJdbcConnection() throws DdlException {
try {
+ initLocalObjectsImpl();
Review Comment:
Why move this method to here?
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcClickHouseClient.java:
##########
@@ -121,4 +212,40 @@ protected Type jdbcTypeToDoris(JdbcFieldSchema
fieldSchema) {
return Type.UNSUPPORTED;
}
}
+
+ /**
+ * Determine whether the driver version is greater than or equal to 0.5.0.
+ */
+ private boolean isNewClickHouseDriver(String driverVersion) {
+ try {
+ String[] versionParts = driverVersion.split("\\.");
+ int majorVersion = Integer.parseInt(versionParts[0]);
+ int minorVersion = Integer.parseInt(versionParts[1]);
+ // 判断是否大于等于 0.5.x
Review Comment:
English.
And we should add UT for this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
