starocean999 commented on code in PR #46995: URL: https://github.com/apache/doris/pull/46995#discussion_r1915037103
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropTableCommand.java: ########## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.commands; + +import com.google.common.base.Strings; +import org.apache.doris.analysis.DropTableStmt; +import org.apache.doris.analysis.StmtType; +import org.apache.doris.analysis.TableName; +import org.apache.doris.catalog.Env; +import org.apache.doris.common.ErrorCode; +import org.apache.doris.common.ErrorReport; +import org.apache.doris.common.util.InternalDatabaseUtil; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.qe.StmtExecutor; + +public class DropTableCommand extends Command implements ForwardWithSync { + + private boolean ifExists; + private final TableName tableName; + private final boolean isView; + private boolean forceDrop; + private boolean isMaterializedView; + + public DropTableCommand(boolean ifExists, TableName tableName, boolean forceDrop) { + super(PlanType.DROP_TABLE_COMMAND); + this.ifExists = ifExists; + this.tableName = tableName; + this.isView = false; + this.forceDrop = forceDrop; + } + + public DropTableCommand(boolean ifExists, TableName tableName, boolean isView, boolean forceDrop) { + super(PlanType.DROP_TABLE_COMMAND); + this.ifExists = ifExists; + this.tableName = tableName; + this.isView = isView; + this.forceDrop = forceDrop; + } + + @Override + public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { + return visitor.visitDropTableCommand(this, context); + } + + + @Override + public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { + if (Strings.isNullOrEmpty(tableName.getDb())) { + tableName.setDb(ctx.getDatabase()); + } + tableName.analyze(ctx); + InternalDatabaseUtil.checkDatabase(tableName.getDb(), ctx); + // check access + if (!Env.getCurrentEnv().getAccessManager() + .checkTblPriv(ConnectContext.get(), tableName.getCtl(), tableName.getDb(), + tableName.getTbl(), PrivPredicate.DROP)) { + ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "DROP"); + } + Env.getCurrentEnv().dropTable(new DropTableStmt(ifExists, tableName, forceDrop)); Review Comment: it's better to change the interface to remove the dependence of DropTableStmt. You can take https://github.com/apache/doris/pull/42935 as reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
