CalvinKirs commented on code in PR #46398:
URL: https://github.com/apache/doris/pull/46398#discussion_r1917812262
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -213,16 +254,16 @@ private List<Split> doGetSplits(int numBackends) throws
UserException {
this.pushdownIcebergPredicates.add(predicate.toString());
}
- // get splits
- List<Split> splits = new ArrayList<>();
- int formatVersion = ((BaseTable)
icebergTable).operations().current().formatVersion();
- HashSet<String> partitionPathSet = new HashSet<>();
- boolean isPartitionedTable = icebergTable.spec().isPartitioned();
+ scan = scan.planWith(source.getCatalog().getThreadPool());
+
+ return scan;
+ }
- long realFileSplitSize = getRealFileSplitSize(0);
- CloseableIterable<FileScanTask> fileScanTasks = null;
+ public CloseableIterable<FileScanTask> planFileScanTask(TableScan scan) {
+ long targetSplitSize = getRealFileSplitSize(0);
+ CloseableIterable<FileScanTask> splitFiles;
try {
- fileScanTasks = TableScanUtil.splitFiles(scan.planFiles(),
realFileSplitSize);
+ splitFiles = TableScanUtil.splitFiles(scan.planFiles(),
targetSplitSize);
Review Comment:
This will read from HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
