adonis0147 commented on code in PR #10195:
URL: https://github.com/apache/incubator-doris/pull/10195#discussion_r899836878
##########
be/src/exprs/block_bloom_filter_impl.cc:
##########
@@ -83,17 +85,26 @@ Status BlockBloomFilter::init(const int log_space_bytes,
uint32_t hash_seed) {
return Status::OK();
}
-Status BlockBloomFilter::init_from_directory(int log_space_bytes, const Slice&
directory,
- bool always_false, uint32_t
hash_seed) {
+Status BlockBloomFilter::init_from_directory(int log_space_bytes,
+
butil::IOBufAsZeroCopyInputStream* data,
+ const size_t& data_size, bool
always_false,
+ uint32_t hash_seed) {
RETURN_IF_ERROR(init_internal(log_space_bytes, hash_seed));
DCHECK(_directory);
- if (directory_size() != directory.size) {
+ if (directory_size() != data_size) {
return Status::InvalidArgument(fmt::format(
"Mismatch in BlockBloomFilter source directory size {} and
expected size {}",
- directory.size, directory_size()));
+ data_size, directory_size()));
+ }
+ int size = 0;
+ char* tmp;
+ const void** ptr = (const void**)&tmp;
+ char* data_ptr = reinterpret_cast<char*>(_directory);
+ while (data->Next(ptr, &size)) {
+ memcpy(data_ptr, *ptr, size);
+ data_ptr += size;
Review Comment:
I didn't mean to use `Slice`. I think you could create another `struct`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
