morrySnow commented on code in PR #1817:
URL: https://github.com/apache/doris-website/pull/1817#discussion_r1918251437
##########
docs/sql-manual/sql-functions/table-valued-functions/iceberg-meta.md:
##########
Review Comment:
同 hudi_meta
##########
docs/sql-manual/sql-functions/table-valued-functions/hudi-meta.md:
##########
@@ -32,64 +32,63 @@ hudi_meta table-valued-function(tvf), using for read hudi
metadata, operation hi
## Syntax
```sql
-hudi_meta(
- "table" = "ctl.db.tbl",
- "query_type" = "timeline"
- ...
+HUDI_META(
+ "table" = "<table>",
+ "query_type" = "<query_type>"
+ [, ...]
Review Comment:
还有其他参数嘛？如果没有就去掉后面的 [, ...] 如果有，需要再参数中说明。可以使用 <optional_properties> 然后把所有的
key 在可选参数说明中列举。
##########
docs/sql-manual/sql-functions/table-valued-functions/hudi-meta.md:
##########
@@ -32,64 +32,63 @@ hudi_meta table-valued-function(tvf), using for read hudi
metadata, operation hi
## Syntax
```sql
-hudi_meta(
- "table" = "ctl.db.tbl",
- "query_type" = "timeline"
- ...
+HUDI_META(
+ "table" = "<table>",
+ "query_type" = "<query_type>"
+ [, ...]
);
```
-**parameter description**
+## Required Parameters
+**1. `<table>`**
+- `table`: The full table name, which must be specified in the format of
`database_name.table_name` for the hudi table that you want to view.
-Each parameter in hudi_meta tvf is a pair of `"key"="value"`.
+**2. `<query_type>`**
+- `query_type`: The type of metadata you want to view. Currently, only
`timeline` is supported.
-Related parameters:
-- `table`： (required) Use hudi table name the format `catlog.database.table`.
-- `query_type`： (required) The type of hudi metadata. Only `timeline` is
currently supported.
+## Usage Notes
+- Each parameter in the `hudi_meta` table function (tvf) is a `"key"="value"`
pair.
-## Example
-
Review Comment:
这句话放到参数说明中
##########
docs/sql-manual/sql-functions/table-valued-functions/local.md:
##########
@@ -157,31 +143,18 @@ mysql> select * from local(
```
Can be used with `desc function` :
-
```sql
-mysql> desc function local(
+desc function local(
"file_path" = "student.csv",
"backend_id" = "10003",
"format" = "csv");
+```
+```text
+-------+------+------+-------+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+-------+------+------+-------+---------+-------+
| c1 | TEXT | Yes | false | NULL | NONE |
| c2 | TEXT | Yes | false | NULL | NONE |
| c3 | TEXT | Yes | false | NULL | NONE |
+-------+------+------+-------+---------+-------+
-```
-
-### Keywords
-
-local, table-valued-function, tvf
-
-### Best Practice
-
-- For more detailed usage of local tvf, please refer to [S3](./s3.md) tvf, The
only difference between them is the way of accessing the storage system.
-
-- Access data on NAS through local tvf
-
- NAS shared storage allows to be mounted to multiple nodes at the same
time. Each node can access files in the shared storage just like local files.
Therefore, the NAS can be thought of as a local file system, accessed through
local tvf.
-
- When setting `"shared_storage" = "true"`, Doris will think that the
specified file can be accessed from any BE node. When a set of files is
specified using wildcards, Doris will distribute requests to access files to
multiple BE nodes, so that multiple nodes can be used to perform distributed
file scanning and improve query performance.
Review Comment:
这段可以保留一下，放到描述里面
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
