jacktengg commented on code in PR #47201:
URL: https://github.com/apache/doris/pull/47201#discussion_r1921697431
##########
be/src/olap/rowset/beta_rowset.cpp:
##########
@@ -68,9 +69,23 @@ Status BetaRowset::init() {
return Status::OK(); // no op
}
-Status BetaRowset::do_load(bool /*use_cache*/) {
- // do nothing.
- // the segments in this rowset will be loaded by calling load_segments()
explicitly.
+Status BetaRowset::get_segment_num_rows(std::vector<uint32_t>* segment_rows) {
+ DCHECK(_rowset_state_machine.rowset_state() == ROWSET_LOADED);
+
+ RETURN_IF_ERROR(_load_segment_rows_once.call([this] {
+ auto segment_count = num_segments();
+ _segments_rows.resize(segment_count);
+ for (int64_t i = 0; i != segment_count; ++i) {
+ SegmentCacheHandle segment_cache_handle;
+ RETURN_IF_ERROR(SegmentLoader::instance()->load_segment(
+ std::static_pointer_cast<BetaRowset>(shared_from_this()),
i,
+ &segment_cache_handle, false, false));
+ const auto& tmp_segments = segment_cache_handle.get_segments();
+ _segments_rows[i] = tmp_segments[0]->num_rows();
Review Comment:
If it reaches line 83, it means `SegmentLoader::instance()->load_segment`
returns `OK` and it assures `segment_cache_handle.get_segments()` is not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
