cosven commented on code in PR #47375:
URL: https://github.com/apache/doris/pull/47375#discussion_r1928028627
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1685,7 +1685,7 @@ static bool check_delete_bitmap_lock(MetaServiceCode&
code, std::string& msg, st
std::string lock_key = meta_delete_bitmap_update_lock_key({instance_id,
table_id, -1});
std::string lock_val;
DeleteBitmapUpdateLockPB lock_info;
- auto err = txn->get(lock_key, &lock_val);
+ auto err = txn->get(lock_key, &lock_val, lock_id == -1 /*snapshot*/);
Review Comment:
We should add some unit/p0 tests to verify this branch.
At least, the following test case should be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
