morrySnow commented on code in PR #10270:
URL: https://github.com/apache/doris/pull/10270#discussion_r902583944
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -17,14 +17,19 @@
package org.apache.doris.nereids.memo;
+import org.apache.doris.common.Pair;
import org.apache.doris.nereids.operators.Operator;
+import org.apache.doris.nereids.properties.PhysicalProperties;
import org.apache.doris.nereids.rules.Rule;
import org.apache.doris.nereids.rules.RuleType;
import com.clearspring.analytics.util.Lists;
Review Comment:
```suggestion
import com.google.common.collect.Lists;
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -166,12 +174,33 @@ public void setExplored(boolean explored) {
* @return {@link Optional} of cost and {@link GroupExpression} of
physical plan pair.
*/
public Optional<Pair<Double, GroupExpression>>
getLowestCostPlan(PhysicalProperties physicalProperties) {
- if (physicalProperties == null ||
CollectionUtils.isEmpty(lowestCostPlans)) {
+ if (physicalProperties == null || lowestCostPlans.isEmpty()) {
Review Comment:
if change to `lowestCostPlans.isEmpty()`, you need to initialize it in
constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
