xiaokang commented on code in PR #10169:
URL: https://github.com/apache/doris/pull/10169#discussion_r904431043
##########
be/src/vec/functions/like.cpp:
##########
@@ -129,6 +130,42 @@ Status FunctionLikeBase::vector_vector(const
ColumnString::Chars& values,
const ColumnString::Offsets&
pattern_offsets,
ColumnUInt8::Container& result, const
LikeFn& function,
LikeSearchState* search_state) {
+ // for constant_substring_fn, use long run length search for performance
+ if (constant_substring_fn ==
Review Comment:
There are different functions vectorVector, vectorConstant, constantVector
for FunctionsStringSearch in clickhouse.
There are some difference between FunctionsStringSearch in clickhouse and
like in doris.
We have many constant functions in like, such as constant_equals_fn,
constant_starts_with_fn, constant_ends_with_fn, constant_substring_fn. We still
need to add this special branch for constant_substring_fn, since we need to do
special optimization for substring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
