CalvinKirs opened a new pull request, #47738:
URL: https://github.com/apache/doris/pull/47738
## Background:
Currently, when creating an HMS Catalog, users are required to explicitly
declare certain configuration parameters (e.g., dfs) in the CREATE CATALOG
statement. However, if users have provided these parameters in a configuration
file (e.g., XML file), the parameters in the SQL statement become redundant. To
simplify the user experience and reduce unnecessary configuration, we decided
to move the parameter validation to the backend, load the configuration file
first, and then check if the necessary parameters are present.
## Changes:
The parameter validation is moved from the CREATE CATALOG statement to the
backend logic. The CREATE CATALOG statement is simplified to the following:
```
sql
Edit
CREATE CATALOG `hms_test` PROPERTIES (
"type" = "hms"
);
```
We will load configuration files (e.g., XML), then validate whether the
required parameters are present. If any necessary parameters are missing, an
error will be triggered to ensure the user's configuration is complete.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
