This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 13c8b1797db [fix](nereids)fix logical repeat computefd (#47798)
13c8b1797db is described below
commit 13c8b1797dbf5ea85ff91db3fbd2484d556cc0ea
Author: xzj7019 <[email protected]>
AuthorDate: Thu Feb 13 16:27:30 2025 +0800
[fix](nereids)fix logical repeat computefd (#47798)
---
.../doris/nereids/trees/plans/logical/LogicalRepeat.java | 9 ++-------
.../nereids/properties/FunctionalDependenciesTest.java | 15 ++++++++-------
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
index 9c24fab3352..8fb7ef5e4ad 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
@@ -192,17 +192,12 @@ public class LogicalRepeat<CHILD_TYPE extends Plan>
extends LogicalUnary<CHILD_T
@Override
public void computeUniform(FunctionalDependencies.Builder fdBuilder) {
-
fdBuilder.addUniformSlot(child(0).getLogicalProperties().getFunctionalDependencies());
+ // don't generate uniform slot
}
@Override
public ImmutableSet<FdItem> computeFdItems() {
- ImmutableSet.Builder<FdItem> builder = ImmutableSet.builder();
-
- ImmutableSet<FdItem> childItems =
child().getLogicalProperties().getFunctionalDependencies().getFdItems();
- builder.addAll(childItems);
-
- return builder.build();
+ return ImmutableSet.of();
}
@Override
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/FunctionalDependenciesTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/FunctionalDependenciesTest.java
index d6f82169140..12823e40298 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/FunctionalDependenciesTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/FunctionalDependenciesTest.java
@@ -236,13 +236,14 @@ class FunctionalDependenciesTest extends
TestWithFeService {
Assertions.assertTrue(plan.getLogicalProperties()
.getFunctionalDependencies().isUniformAndNotNull(plan.getOutput().get(0)));
- plan = PlanChecker.from(connectContext)
- .analyze("select id from agg where id = 1 group by cube(id,
name)")
- .rewrite()
- .getPlan();
-
System.out.println(plan.getLogicalProperties().getFunctionalDependencies());
- Assertions.assertTrue(plan.getLogicalProperties()
-
.getFunctionalDependencies().isUniform(plan.getOutput().get(0)));
+ // comment this ut since repeat's uniform and fd are disabled in this
version
+ //plan = PlanChecker.from(connectContext)
+ // .analyze("select id from agg where id = 1 group by cube(id,
name)")
+ // .rewrite()
+ // .getPlan();
+
//System.out.println(plan.getLogicalProperties().getFunctionalDependencies());
+ //Assertions.assertTrue(plan.getLogicalProperties()
+ //
.getFunctionalDependencies().isUniform(plan.getOutput().get(0)));
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
