wuyunfeng commented on code in PR #10391:
URL: https://github.com/apache/doris/pull/10391#discussion_r906666577
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/EsTable.java:
##########
@@ -73,7 +73,7 @@ public class EsTable extends Table {
private String indexName;
// which type used for `indexName`, default to `_doc`
Review Comment:
```suggestion
// which type used for `indexName`
```
##########
docs/en/docs/ecosystem/external-table/doris-on-es.md:
##########
@@ -121,7 +121,7 @@ PROPERTIES (
"hosts" = "http://192.168.0.1:8200,http://192.168.0.2:8200";,
"index" = "test",
"type" = "doc",
-
+"version" = "6.8.23"
Review Comment:
remove this line
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/EsTable.java:
##########
@@ -263,8 +261,8 @@ private void validate(Map<String, String> properties)
throws DdlException {
public TTableDescriptor toThrift() {
TEsTable tEsTable = new TEsTable();
- TTableDescriptor tTableDescriptor = new TTableDescriptor(getId(),
TTableType.ES_TABLE,
- fullSchema.size(), 0, getName(), "");
+ TTableDescriptor tTableDescriptor = new TTableDescriptor(getId(),
TTableType.ES_TABLE, fullSchema.size(), 0,
+ getName(), "");
Review Comment:
getSignature method should process mappingType is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
