Gabriel39 commented on code in PR #10460:
URL: https://github.com/apache/doris/pull/10460#discussion_r907941300
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -159,6 +159,7 @@ class SegmentIterator : public RowwiseIterator {
std::vector<ColumnId>
_short_cir_pred_column_ids; // keep columnId of columns for short
circuit predicate evaluation
std::vector<bool> _is_first_read_column; // columns hold by segmentIter
+ std::vector<bool> _is_predicate_column; // columns hold by segmentIter
Review Comment:
try not to use `vector<bool>`. Use `vector<char>` or `bitset` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
