qzsee commented on code in PR #10462:
URL: https://github.com/apache/doris/pull/10462#discussion_r908113857
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/CompoundPredicate.java:
##########
@@ -37,13 +39,31 @@ public CompoundPredicate(NodeType type, LEFT_CHILD_TYPE
left, RIGHT_CHILD_TYPE r
super(type, left, right);
}
+ @Override
+ public String toString() {
+ return sql();
+ }
+
@Override
public String sql() {
String nodeType = getType().toString();
- return left().sql() + ' ' + nodeType + ' ' + right().sql();
+ return left() + " " + nodeType + " " + right();
Review Comment:
Some expressions implement toString but not implement toSql. Unified
implementation of SQL () is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
