Gabriel39 commented on code in PR #47788:
URL: https://github.com/apache/doris/pull/47788#discussion_r1961440357
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -124,25 +125,26 @@ class BloomFilterFuncBase : public RuntimeFilterFuncBase {
void init_params(const RuntimeFilterParams* params) {
_bloom_filter_length = params->bloom_filter_size;
- _build_bf_exactly = params->build_bf_exactly;
+ _build_bf_by_runtime_size = params->build_bf_exactly;
Review Comment:
```suggestion
_build_bf_by_runtime_size = params->build_bf_by_runtime_size;
```
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -124,25 +125,26 @@ class BloomFilterFuncBase : public RuntimeFilterFuncBase {
void init_params(const RuntimeFilterParams* params) {
_bloom_filter_length = params->bloom_filter_size;
- _build_bf_exactly = params->build_bf_exactly;
+ _build_bf_by_runtime_size = params->build_bf_exactly;
_runtime_bloom_filter_min_size = params->runtime_bloom_filter_min_size;
_runtime_bloom_filter_max_size = params->runtime_bloom_filter_max_size;
_null_aware = params->null_aware;
_bloom_filter_size_calculated_by_ndv =
params->bloom_filter_size_calculated_by_ndv;
+ _enable_fixed_len_to_uint32_v2 = params->enable_fixed_len_to_uint32_v2;
_limit_length();
}
Status init_with_fixed_length() { return
init_with_fixed_length(_bloom_filter_length); }
- bool get_build_bf_cardinality() const { return _build_bf_exactly; }
+ bool build_bf_by_runtime_size() const { return _build_bf_by_runtime_size; }
- Status init_with_cardinality(const size_t build_bf_cardinality) {
- if (_build_bf_exactly) {
+ Status init_with_cardinality(const size_t runtime_size) {
Review Comment:
```suggestion
Status init_with_cardinality(const size_t cardinality) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
