EmmyMiao87 commented on code in PR #10483:
URL: https://github.com/apache/doris/pull/10483#discussion_r909256844
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -184,7 +184,7 @@ public void setExplored(boolean explored) {
* @return {@link Optional} of cost and {@link GroupExpression} of
physical plan pair.
*/
public Optional<Pair<Double, GroupExpression>>
getLowestCostPlan(PhysicalProperties physicalProperties) {
- if (physicalProperties == null || lowestCostPlans.isEmpty()) {
+ if (physicalProperties == null || lowestCostPlans == null ||
lowestCostPlans.isEmpty()) {
Review Comment:
The lowestCostPlans hash been initialed in Line.49. So the lowest cost plans
could not be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
