yinzhijian commented on code in PR #10377:
URL: https://github.com/apache/doris/pull/10377#discussion_r909264832
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -567,13 +578,26 @@ public Expression withPredicate(PredicateContext ctx,
Expression e) {
* @return Expression
*/
public Expression withBetween(PredicateContext ctx, Expression e) {
- boolean isNotBetween = ctx.NOT() != null ? true : false;
BetweenPredicate betweenPredicate = new BetweenPredicate(
e,
expression(ctx.lower),
expression(ctx.upper)
);
- return isNotBetween ? new Not(betweenPredicate) : betweenPredicate;
+ return betweenPredicate;
Review Comment:
The variable betweenPredicate seems redundant and can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
