morrySnow commented on code in PR #10499:
URL: https://github.com/apache/doris/pull/10499#discussion_r910253168
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PhysicalPlanTranslator.java:
##########
@@ -263,7 +279,43 @@ public PlanFragment visitPhysicalHashJoin(
@Override
public PlanFragment visitPhysicalProject(
PhysicalUnaryPlan<PhysicalProject, Plan> projectPlan,
PlanTranslatorContext context) {
- return visit(projectPlan.child(0), context);
+ PhysicalProject physicalProject = projectPlan.getOperator();
+ List<Expr> execExprList = physicalProject.getProjects()
+ .stream()
+ .map(e -> ExpressionConverter.convert(e, context))
+ .collect(Collectors.toList());
+ PlanFragment inputFragment = visit(projectPlan.child(0), context);
+ PlanNode planNode = inputFragment.getPlanRoot();
+ List<Expr> conjunctList = planNode.getConjuncts();
Review Comment:
```suggestion
List<Expr> inputPredicates = planNode.getConjuncts();
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PhysicalPlanTranslator.java:
##########
@@ -263,7 +279,43 @@ public PlanFragment visitPhysicalHashJoin(
@Override
public PlanFragment visitPhysicalProject(
PhysicalUnaryPlan<PhysicalProject, Plan> projectPlan,
PlanTranslatorContext context) {
- return visit(projectPlan.child(0), context);
+ PhysicalProject physicalProject = projectPlan.getOperator();
+ List<Expr> execExprList = physicalProject.getProjects()
Review Comment:
```suggestion
List<Expr> projectExprList = physicalProject.getProjects()
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PhysicalPlanTranslator.java:
##########
@@ -263,7 +279,43 @@ public PlanFragment visitPhysicalHashJoin(
@Override
public PlanFragment visitPhysicalProject(
PhysicalUnaryPlan<PhysicalProject, Plan> projectPlan,
PlanTranslatorContext context) {
- return visit(projectPlan.child(0), context);
+ PhysicalProject physicalProject = projectPlan.getOperator();
+ List<Expr> execExprList = physicalProject.getProjects()
+ .stream()
+ .map(e -> ExpressionConverter.convert(e, context))
+ .collect(Collectors.toList());
+ PlanFragment inputFragment = visit(projectPlan.child(0), context);
+ PlanNode planNode = inputFragment.getPlanRoot();
Review Comment:
```suggestion
PlanNode inputNode = inputFragment.getPlanRoot();
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PhysicalPlanTranslator.java:
##########
@@ -263,7 +279,43 @@ public PlanFragment visitPhysicalHashJoin(
@Override
public PlanFragment visitPhysicalProject(
PhysicalUnaryPlan<PhysicalProject, Plan> projectPlan,
PlanTranslatorContext context) {
- return visit(projectPlan.child(0), context);
+ PhysicalProject physicalProject = projectPlan.getOperator();
+ List<Expr> execExprList = physicalProject.getProjects()
+ .stream()
+ .map(e -> ExpressionConverter.convert(e, context))
+ .collect(Collectors.toList());
+ PlanFragment inputFragment = visit(projectPlan.child(0), context);
+ PlanNode planNode = inputFragment.getPlanRoot();
+ List<Expr> conjunctList = planNode.getConjuncts();
+ Set<Integer> slotIdList = new HashSet<>();
Review Comment:
```suggestion
Set<Integer> requiredSlotIds = new HashSet<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
