morningman commented on code in PR #10534:
URL: https://github.com/apache/doris/pull/10534#discussion_r911566343
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -117,12 +119,12 @@ Status VOlapTableSink::send(RuntimeState* state,
vectorized::Block* input_block)
_partition_to_tablet_map.clear();
}
- //if pending bytes is more than 500M, wait
+ //if pending bytes is more than 500M, abort task
constexpr size_t MAX_PENDING_BYTES = 500 * 1024 * 1024;
- if ( get_pending_bytes() > MAX_PENDING_BYTES){
- while(get_pending_bytes() < MAX_PENDING_BYTES){
- std::this_thread::sleep_for(std::chrono::microseconds(500));
- }
+ if (get_pending_bytes() > MAX_PENDING_BYTES) {
Review Comment:
Not a good fix.
If the data size in a single batch is larger than 500MB, user can not load
data anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
