SWJTU-ZhangLei commented on code in PR #48073:
URL: https://github.com/apache/doris/pull/48073#discussion_r1971524509
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/AzureResource.java:
##########
@@ -78,21 +81,56 @@ protected void setProperties(Map<String, String>
newProperties) throws DdlExcept
this.properties = newProperties;
}
- private static void pingAzure(String bucketName, String rootPath,
+ protected static void pingAzure(String bucketName, String rootPath,
Map<String, String> newProperties) throws DdlException {
- if (FeConstants.runningUnitTest) {
- return;
+
+ String testFile = "azure://" + bucketName + "/" + rootPath + "/"
+ + UUID.randomUUID().toString() + "/test-object-valid.txt";
+
+ byte[] contentData = new byte[2 * ObjStorage.CHUNK_SIZE];
+ Arrays.fill(contentData, (byte) 'A');
+ AzureObjStorage azureObjStorage = new AzureObjStorage(newProperties);
+
+ Status status = azureObjStorage.putObject(testFile, new
ByteArrayInputStream(contentData), contentData.length);
+ if (!Status.OK.equals(status)) {
+ throw new DdlException(
+ "ping azure failed(put), status: " + status + ",
properties: " + new PrintableMap<>(
+ newProperties, "=", true, false, true, false));
}
- String testFile = "azure://" + bucketName + "/" + rootPath +
"/test-object-valid.txt";
- AzureFileSystem fileSystem = new AzureFileSystem(newProperties);
- Status status = fileSystem.exists(testFile);
- if (status != Status.OK && status.getErrCode() !=
Status.ErrCode.NOT_FOUND) {
+ status = azureObjStorage.headObject(testFile);
+ if (!Status.OK.equals(status)) {
throw new DdlException(
"ping azure failed(head), status: " + status + ",
properties: " + new PrintableMap<>(
newProperties, "=", true, false, true, false));
}
- LOG.info("success to ping azure");
+
+ RemoteObjects remoteObjects = azureObjStorage.listObjects(testFile,
null);
+ LOG.info("remoteObjects: {}", remoteObjects);
+ Preconditions.checkArgument(remoteObjects.getObjectList().size() == 1,
"remoteObjects.size() must equal 1");
+
+ status = azureObjStorage.deleteObject(testFile);
+ if (!Status.OK.equals(status)) {
+ throw new DdlException(
+ "ping azure failed(delete), status: " + status + ",
properties: " + new PrintableMap<>(
+ newProperties, "=", true, false, true, false));
+ }
+
+ status = azureObjStorage.multiPartPutObject(testFile,
Review Comment:
> abort should be also considered
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
