yiguolei commented on code in PR #48368:
URL: https://github.com/apache/doris/pull/48368#discussion_r1976232369


##########
be/src/runtime/result_buffer_mgr.cpp:
##########
@@ -95,7 +104,8 @@ Status ResultBufferMgr::create_sender(const TUniqueId& 
query_id, int buffer_size
     return Status::OK();
 }
 
-std::shared_ptr<BufferControlBlock> ResultBufferMgr::find_control_block(const 
TUniqueId& query_id) {
+std::shared_ptr<ResultBlockBufferBase> ResultBufferMgr::find_control_block(

Review Comment:
   这样外部系统访问的时候,就可以省去cast 开销了,并且,在这个函数里,我们需要assert cast检查为true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to