BiteTheDDDDt commented on code in PR #10582:
URL: https://github.com/apache/doris/pull/10582#discussion_r912885701
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -990,15 +992,23 @@ void
DefaultValueColumnIterator::insert_default_data(const TypeInfo* type_info,
Status DefaultValueColumnIterator::next_batch(size_t* n,
vectorized::MutableColumnPtr& dst,
bool* has_null) {
+ *has_null = _is_default_value_null;
+ _insert_many_default(dst, *n);
+ return Status::OK();
+}
+
+Status DefaultValueColumnIterator::read_by_rowids(const rowid_t* rowids, const
size_t count,
+
vectorized::MutableColumnPtr& dst) {
+ _insert_many_default(dst, count);
+ return Status::OK();
+}
+
+void
DefaultValueColumnIterator::_insert_many_default(vectorized::MutableColumnPtr&
dst, size_t n) {
if (_is_default_value_null) {
- *has_null = true;
- dst->insert_many_defaults(*n);
+ dst->insert_many_defaults(n);
Review Comment:
The input of function `read_by_rowids` does not contain `has_null`, so it is
no needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
