gavinchou commented on code in PR #48687:
URL: https://github.com/apache/doris/pull/48687#discussion_r1982604733
##########
be/src/io/cache/fs_file_cache_storage.cpp:
##########
@@ -309,15 +309,31 @@ std::string
FSFileCacheStorage::get_path_in_local_cache(const UInt128Wrapper& va
}
Status FSFileCacheStorage::upgrade_cache_dir_if_necessary() const {
- /// version 1.0: cache_base_path / key / offset
- /// version 2.0: cache_base_path / key_prefix / key / offset
+ /*
Review Comment:
add more log to show whether we need to "upgrade", print previous and
current version before right after "read_file_cache_version"
add some stats like file count, time consumption and etc when upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
