Lchangliang commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r914359306
##########
be/src/olap/schema_change.cpp:
##########
@@ -1649,8 +1650,8 @@ Status VSchemaChangeWithSorting::_internal_sorting(
MultiBlockMerger merger(new_tablet);
std::unique_ptr<RowsetWriter> rowset_writer;
- RETURN_IF_ERROR(
- new_tablet->create_rowset_writer(version, VISIBLE,
segments_overlap, &rowset_writer));
+ RETURN_IF_ERROR(new_tablet->create_rowset_writer(version, VISIBLE,
segments_overlap,
+
&new_tablet->tablet_schema(), &rowset_writer));
Review Comment:
it is not only use for new_tablet. Such as PushHandler::_convert_v2,
Compaction::construct_output_rowset_writer. They should set newer schema from
outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
