gavinchou commented on code in PR #48786:
URL: https://github.com/apache/doris/pull/48786#discussion_r1983610695
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -229,5 +235,50 @@ Status PageIO::read_and_decompress_page_(const
PageReadOptions& opts, PageHandle
return Status::OK();
}
+io::UInt128Wrapper file_cache_key_from_path(const std::string& seg_path) {
+ std::string base = seg_path.substr(seg_path.rfind('/') + 1); // tricky:
npos + 1 == 0
+ return io::BlockFileCache::hash(base);
+}
+
+std::string file_cache_key_str(const std::string& seg_path) {
+ return file_cache_key_from_path(seg_path).to_string();
+}
+
+Status PageIO::read_and_decompress_page_with_file_cache_retry(const
PageReadOptions& opts,
Review Comment:
where is this function is called?
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -229,5 +235,50 @@ Status PageIO::read_and_decompress_page_(const
PageReadOptions& opts, PageHandle
return Status::OK();
}
+io::UInt128Wrapper file_cache_key_from_path(const std::string& seg_path) {
Review Comment:
is it mandatory to introduce file cache to PageIO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
