airborne12 commented on code in PR #48890:
URL: https://github.com/apache/doris/pull/48890#discussion_r1990668142
##########
be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp:
##########
@@ -201,7 +200,9 @@
DorisCompoundReader::DorisCompoundReader(CL_NS(store)::IndexInput* stream, int32
_entries->put(aid, entry);
// read header file data
if (entry->offset < 0) {
- copyFile(entry->file_name.c_str(), entry->length, buffer,
BUFFER_LENGTH);
+ //if offset is -1, it means it's size is lower than
DorisFSDirectory::MAX_HEADER_DATA_SIZE, which is 128k.
+ _copyFile(entry->file_name.c_str(),
static_cast<int32_t>(entry->length), buffer,
Review Comment:
if offset is -1, it means it's size is lower than
DorisFSDirectory::MAX_HEADER_DATA_SIZE, which is 128k.
so entry->length must be lower than int32 max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
