yiguolei commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r916444639
##########
be/src/olap/delta_writer.h:
##########
@@ -116,7 +122,11 @@ class DeltaWriter {
// TODO: Recheck the lifetime of _mem_table, Look should use unique_ptr
std::shared_ptr<MemTable> _mem_table;
std::unique_ptr<Schema> _schema;
- const TabletSchema* _tablet_schema;
+ //const TabletSchema* _tablet_schema;
+ // tablet schema owned by delta writer, all write will use this tablet
schema
+ // it's build from tablet_schema（stored when create tablet） and
OlapTableSchema
+ // every request will have it's own tablet schema so simple schema change
can work
+ std::shared_ptr<TabletSchema> _tablet_schema;
Review Comment:
why not unique ptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
