liaoxin01 commented on code in PR #48965:
URL: https://github.com/apache/doris/pull/48965#discussion_r1991684652
##########
be/src/http/action/stream_load.cpp:
##########
@@ -337,6 +337,8 @@ Status StreamLoadAction::_on_header(HttpRequest* http_req,
std::shared_ptr<Strea
ctx->timeout_second = std::stoi(http_req->header(HTTP_TIMEOUT));
} catch (const std::invalid_argument& e) {
return Status::InvalidArgument("Invalid timeout format, {}",
e.what());
+ } catch (const std::out_of_range& e) {
Review Comment:
Please also fix other places that use the stoi function together.
##########
be/src/runtime/stream_load/stream_load_context.h:
##########
@@ -157,7 +157,7 @@ class StreamLoadContext {
// optional
std::string sub_label;
double max_filter_ratio = 0.0;
- int32_t timeout_second = -1;
+ int64_t timeout_second = -1;
Review Comment:
We don't need to change this type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
