BiteTheDDDDt commented on code in PR #10700:
URL: https://github.com/apache/doris/pull/10700#discussion_r916867517
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1034,6 +1049,12 @@ Status
AggregationNode::_merge_with_serialized_key(Block* block) {
using HashMethodType = std::decay_t<decltype(agg_method)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
+ if constexpr
(ColumnsHashing::IsPreSerializedKeysHashMethodTraits<
+ AggState>::value) {
+ SCOPED_TIMER(_serialize_key_timer);
Review Comment:
Maybe we can do some abstract for those same code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
