csun5285 commented on code in PR #48988:
URL: https://github.com/apache/doris/pull/48988#discussion_r1993329436
##########
fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java:
##########
@@ -251,6 +252,13 @@ private void
createShadowIndexReplicaForPartition(OlapTable tbl) throws Exceptio
long originIndexId = indexIdMap.get(shadowIdxId);
KeysType originKeysType =
tbl.getKeysTypeByIndexId(originIndexId);
List<Index> tabletIndexes = originIndexId ==
tbl.getBaseIndexId() ? indexes : null;
+ Map<Index, List<Integer>> indexListMap = null;
Review Comment:
move this to `createTabletMetaBuilder`
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##########
@@ -300,7 +307,7 @@ protected void createShadowIndexReplica() throws
AlterCancelException {
shadowReplicaId,
shadowShortKeyColumnCount, shadowSchemaHash,
Partition.PARTITION_INIT_VERSION,
originKeysType, TStorageType.COLUMN,
storageMedium,
- shadowSchema, bfColumns, bfFpp,
countDownLatch, tabletIndexes,
+ shadowSchema, bfColumns, bfFpp,
countDownLatch, indexListMap,
Review Comment:
no need to change
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##########
@@ -287,6 +287,13 @@ protected void createShadowIndexReplica() throws
AlterCancelException {
KeysType originKeysType =
tbl.getKeysTypeByIndexId(originIndexId);
List<Index> tabletIndexes = originIndexId ==
tbl.getBaseIndexId() ? indexes : null;
+ Map<Index, List<Integer>> indexListMap = null;
Review Comment:
move this to `CreateReplicaTask`
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -3042,6 +3042,18 @@ public void initSchemaColumnUniqueId() {
}
}
+ public List<Integer> getIndexColumnIds(List<String> columnNames) {
Review Comment:
delete it
##########
fe/fe-core/src/main/java/org/apache/doris/alter/IndexChangeJob.java:
##########
@@ -318,6 +320,14 @@ protected void runWaitingTxnJob() throws
AlterCancelException {
int originSchemaHash =
olapTable.getSchemaHashByIndexId(originIndexId);
Partition partition = olapTable.getPartition(partitionId);
MaterializedIndex origIdx = partition.getIndex(originIndexId);
+ Map<Index, List<Integer>> existIndexToColumnUniqueIds = new
HashMap<>();
Review Comment:
delete it, do the same work in `AlterInvertedIndexTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
