ChenMiaoi commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1988319940
##########
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_numeric_arithmatic.groovy:
##########
@@ -440,6 +477,14 @@ suite("fold_constant_numeric_arithmatic") {
testFoldConst("SELECT SIN(1E308) AS sin_case_overflow")
testFoldConst("SELECT sin(0), sin(pi()/2), sin(pi()), sin(3*pi()/2)")
+// Sinh function cases
+ testFoldConst("SELECT SINH(0) AS sinh_case_1"); // sinh(0) = 0
+ testFoldConst("SELECT SINH(1) AS sinh_case_2"); // sinh(1) ≈ 1.175201194
+ testFoldConst("SELECT SINH(-1) AS sinh_case_3"); // sinh(-1) ≈ -1.175201194
+ testFoldConst("SELECT SINH(2) AS sinh_case_4"); // sinh(2) ≈ 3.626860408
+ // testFoldConst("SELECT SINH(1E308) AS sinh_case_overflow"); // Error for
input String "inf"
+ testFoldConst("SELECT SINH(0), SINH(1), SINH(-1), SINH(2)"); // Multi value
Review Comment:
I test `sinh(null)` at commit `282a337c`，it should be test the small case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
