This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new a266d7b040 [bug](be) fix be _quick_compaction_thread_pool without 
shutdown. (#10758)
a266d7b040 is described below

commit a266d7b040c958a4dd5dabb6b33c2bb8c8197679
Author: Lei Zhang <[email protected]>
AuthorDate: Mon Jul 11 22:33:56 2022 +0800

    [bug](be) fix be _quick_compaction_thread_pool without shutdown. (#10758)
---
 be/src/olap/olap_server.cpp    | 11 -----------
 be/src/olap/storage_engine.cpp |  5 +++++
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/be/src/olap/olap_server.cpp b/be/src/olap/olap_server.cpp
index 488f8cccb8..c1d01b9b94 100644
--- a/be/src/olap/olap_server.cpp
+++ b/be/src/olap/olap_server.cpp
@@ -66,17 +66,6 @@ Status StorageEngine::start_bg_threads() {
         data_dirs.push_back(tmp_store.second);
     }
 
-    int32_t max_thread_num = config::max_base_compaction_threads;
-    ThreadPoolBuilder("BaseCompactionTaskThreadPool")
-            .set_min_threads(max_thread_num)
-            .set_max_threads(max_thread_num)
-            .build(&_base_compaction_thread_pool);
-    max_thread_num = config::max_cumu_compaction_threads;
-    ThreadPoolBuilder("CumuCompactionTaskThreadPool")
-            .set_min_threads(max_thread_num)
-            .set_max_threads(max_thread_num)
-            .build(&_cumu_compaction_thread_pool);
-
     ThreadPoolBuilder("BaseCompactionTaskThreadPool")
             .set_min_threads(config::max_base_compaction_threads)
             .set_max_threads(config::max_base_compaction_threads)
diff --git a/be/src/olap/storage_engine.cpp b/be/src/olap/storage_engine.cpp
index c9eec839a5..596ea48f0a 100644
--- a/be/src/olap/storage_engine.cpp
+++ b/be/src/olap/storage_engine.cpp
@@ -161,6 +161,11 @@ StorageEngine::~StorageEngine() {
     if (_cumu_compaction_thread_pool) {
         _cumu_compaction_thread_pool->shutdown();
     }
+
+    if (_quick_compaction_thread_pool) {
+        _quick_compaction_thread_pool->shutdown();
+    }
+
     if (_tablet_meta_checkpoint_thread_pool) {
         _tablet_meta_checkpoint_thread_pool->shutdown();
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to