caiconghui commented on code in PR #10809:
URL: https://github.com/apache/doris/pull/10809#discussion_r921258311
##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -540,7 +540,11 @@ protected boolean cancelImpl(String errMsg) {
private void cancelInternal() {
// clear tasks if has
- AgentTaskQueue.removeBatchTask(rollupBatchTask, TTaskType.ALTER);
+ if (rollupBatchTask != null) {
Review Comment:
> > rollup batch task should not be null？it should be empty？how to reproduce
it？it seems a little serious rollup batch task now will be always initialized,
so it is so strange
>
> maybe in deserialization， rollup batch task will be null ?
the rollup batch task not the serialization/deserialization filed。 so I
think it maybe other proble
##########
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##########
@@ -540,7 +540,11 @@ protected boolean cancelImpl(String errMsg) {
private void cancelInternal() {
// clear tasks if has
- AgentTaskQueue.removeBatchTask(rollupBatchTask, TTaskType.ALTER);
+ if (rollupBatchTask != null) {
Review Comment:
> > rollup batch task should not be null？it should be empty？how to reproduce
it？it seems a little serious rollup batch task now will be always initialized,
so it is so strange
>
> maybe in deserialization， rollup batch task will be null ?
the rollup batch task not the serialization/deserialization filed。 so I
think it maybe other problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
