zddr commented on code in PR #48830:
URL: https://github.com/apache/doris/pull/48830#discussion_r2018487162
##########
fe/fe-core/src/main/java/org/apache/doris/job/task/AbstractTask.java:
##########
@@ -184,7 +184,9 @@ public void runTask() throws JobException {
onFail();
log.warn("execute task error, job id is {}, task id is {}", jobId,
taskId, e);
} finally {
- closeOrReleaseResources();
+ if (!TaskStatus.CANCELED.equals(status)) {
+ closeOrReleaseResources();
Review Comment:
Mtmv is initialized in the before method. If the task has not yet run, the
before method will not be used, so mtmv will be empty, which prevents the
canceled task from being added to the history list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
