yiguolei commented on code in PR #49638:
URL: https://github.com/apache/doris/pull/49638#discussion_r2022419154
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -379,7 +387,7 @@ Status PipelineTask::execute(bool* done) {
Status status = Status::Error<INTERNAL_ERROR>("fault_inject
pipeline_task execute failed");
return status;
});
- if (_wait_to_start()) {
+ if (_wait_to_start() || _wake_up_early) {
Review Comment:
加个注释
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -400,29 +408,17 @@ Status PipelineTask::execute(bool* done) {
}
});
- if (_wake_up_early) {
- _eos = true;
- return Status::OK();
- }
RETURN_IF_ERROR(_open());
}
- auto set_wake_up_and_dep_ready = [&]() {
- if (wake_up_early()) {
- return;
- }
- set_wake_up_early();
- terminate();
- };
-
while (!_fragment_context->is_canceled()) {
Defer defer {[&]() {
// If this run is pended by a spilling request, the block will be
output in next run.
if (!_spilling) {
_block->clear_column_data(_root->row_desc().num_materialized_slots());
}
}};
- if (_is_blocked()) {
+ if (_is_blocked() || _wake_up_early) {
Review Comment:
加个注释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
