wangshuo128 commented on code in PR #10890:
URL: https://github.com/apache/doris/pull/10890#discussion_r923085796
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -36,34 +37,34 @@
public class BindRelation extends OneAnalysisRuleFactory {
@Override
public Rule<Plan> build() {
- // fixme, just for example now
return unboundRelation().thenApply(ctx -> {
ConnectContext connectContext =
ctx.plannerContext.getConnectContext();
List<String> nameParts = ctx.root.getNameParts();
switch (nameParts.size()) {
case 1: {
- List<String> qualifier =
Lists.newArrayList(connectContext.getDatabase(), nameParts.get(0));
- Table table = getTable(qualifier,
connectContext.getCatalog());
+ List<String> qualified =
ImmutableList.of(connectContext.getDatabase(), nameParts.get(0));
Review Comment:
IIUC, `qualifier` is the prefix of `nameParts` except the last one.
Let's say we have a `nameParts` [catalog, db, table], its qualifier should
be [catalog, db], right?
Please correct me if any goes wrong.
The `qualified` in the previous code was meant to fully qualified name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
