gavinchou commented on code in PR #49882:
URL: https://github.com/apache/doris/pull/49882#discussion_r2033158446
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -680,7 +661,27 @@ Status
CloudStorageEngine::_submit_cumulative_compaction_task(const CloudTabletS
tablet->last_cumu_no_suitable_version_ms = 0;
}
};
- st = _cumu_compaction_thread_pool->submit_func([=, this, compaction =
std::move(compaction)]() {
+ Status st = Status::OK();
+ st = _cumu_compaction_thread_pool->submit_func([=, this]() {
+ auto compaction = std::make_shared<CloudCumulativeCompaction>(*this,
tablet);
+ auto st = compaction->prepare_compact();
+ if (!st.ok()) {
+ long now =
duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
+ if (st.is<ErrorCode::CUMULATIVE_NO_SUITABLE_VERSION>() &&
+ st.msg() != "_last_delete_version.first not equal to -1") {
+ // Backoff strategy if no suitable version
+ tablet->last_cumu_no_suitable_version_ms = now;
+ }
+ tablet->set_last_cumu_compaction_failure_time(now);
Review Comment:
LOG if st is not suitable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
