weizuo93 commented on code in PR #10298:
URL: https://github.com/apache/doris/pull/10298#discussion_r923433112
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -102,7 +111,7 @@ Status TabletsChannel::close(int sender_id, int64_t
backend_id, bool* finished,
_state = kFinished;
// All senders are closed
// 1. close all delta writers
- std::vector<DeltaWriter*> need_wait_writers;
+ std::set<DeltaWriter*> need_wait_writers;
Review Comment:
> Why change to std::set?
Element erase operation will follow and std::set is more efficient than
std::vector to execute `erase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
