wary commented on code in PR #309:
URL:
https://github.com/apache/doris-spark-connector/pull/309#discussion_r2041783466
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java:
##########
@@ -114,7 +114,12 @@ private List<Frontend> initFrontends(DorisConfig config)
throws Exception {
+ ", reason: " +
response.getStatusLine().getReasonPhrase());
}
String entity =
EntityUtils.toString(response.getEntity());
- dataNode = extractEntity(entity, "data");
Review Comment:
Does throwing exceptions make it easier to locate issues?
If the user doesn't have permission to call this interface, the program will
throw a null point exception, which can be somewhat misleading. Without prior
experience with such problems, simply logging a message might not make it
easily noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
