amorynan commented on code in PR #50014:
URL: https://github.com/apache/doris/pull/50014#discussion_r2048167874
##########
be/src/vec/data_types/serde/data_type_serde.h:
##########
@@ -97,6 +98,7 @@ struct ColumnVectorBatch;
free(const_cast<char*>(bufferRef.data));
\
bufferRef.data = new_ptr;
\
bufferRef.size = bufferRef.size + BUFFER_UNIT_SIZE;
\
+ buffer_list.back() = bufferRef;
\
Review Comment:
There are still reference to the released memory in buffer_list， should
refresh the reference of bufferRef
##########
be/src/vec/data_types/serde/data_type_serde.h:
##########
@@ -84,6 +84,7 @@ struct ColumnVectorBatch;
bufferRef.data = ptr;
\
bufferRef.size = BUFFER_UNIT_SIZE;
\
size_t offset = 0;
\
+ buffer_list.clear();
\
Review Comment:
yes I will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
