yiguolei commented on code in PR #50310:
URL: https://github.com/apache/doris/pull/50310#discussion_r2055108848
##########
be/src/vec/exprs/table_function/table_function_factory.cpp:
##########
@@ -61,14 +63,21 @@ const std::unordered_map<std::string,
std::function<std::unique_ptr<TableFunctio
{"explode_map", TableFunctionCreator<VExplodeMapTableFunction>
{}},
{"explode_json_object",
TableFunctionCreator<VExplodeJsonObjectTableFunction> {}},
{"posexplode", TableFunctionCreator<VPosExplodeTableFunction>
{}},
- {"explode", TableFunctionCreator<VExplodeTableFunction> {}}};
+ {"explode", TableFunctionCreator<VExplodeV2TableFunction> {}},
+ {"explode_old", TableFunctionCreator<VExplodeTableFunction>
{}}};
Review Comment:
不要用这种old 类似的名字，长期来看，万一后面我们再变动，叫old 没法枚举。
我们叫v1，v2，这样还可以有v3，v4.。。
另外，每个函数后面都得加注释，写明变更的原因，比如是为了支持什么兼容？新功能？之类的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
