yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057419700
##########
be/src/vec/data_types/data_type.h:
##########
@@ -192,12 +193,45 @@ class IDataType : private boost::noncopyable {
static PGenericType_TypeId get_pdata_type(const IDataType* data_type);
- [[nodiscard]] virtual UInt32 get_precision() const {
- throw Exception(ErrorCode::INTERNAL_ERROR, "type {} not support
get_precision", get_name());
+ [[nodiscard]] virtual UInt32 get_precision() const { return 0; }
Review Comment:
这两个函数的默认行为应该得是throw exception。 防止上层误用。
上层调用的时候，都得确保自己是datatype decimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
