xiaokang commented on code in PR #10322:
URL: https://github.com/apache/doris/pull/10322#discussion_r928215324
##########
be/src/vec/exprs/vliteral.cpp:
##########
@@ -118,6 +120,13 @@ void VLiteral::init(const TExprNode& node) {
field = node.string_literal.value;
break;
}
+ case TYPE_JSON: {
+ DCHECK_EQ(node.node_type, TExprNodeType::JSON_LITERAL);
+ DCHECK(node.__isset.json_literal);
+ JsonValue value(node.json_literal.value);
Review Comment:
JsonValue is only used here, is it worth to create a class? maybe include
json parser in JsonField is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
