morningman commented on code in PR #11144:
URL: https://github.com/apache/doris/pull/11144#discussion_r928358670
##########
be/src/olap/merger.cpp:
##########
@@ -41,8 +41,9 @@ Status Merger::merge_rowsets(TabletSharedPtr tablet,
ReaderType reader_type,
reader_params.reader_type = reader_type;
reader_params.rs_readers = src_rowset_readers;
reader_params.version = dst_rowset_writer->version();
-
reader_params.tablet_schema = cur_tablet_schema;
+ reader_params.use_page_cache = false; // shouldn't use page cache
Review Comment:
No need to add this field. We can just use `reader_type` to judge whether to
use page cache.
And for compaction operation, the reader_type is NOT `READER_QUERY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
