dataroaring commented on code in PR #50714:
URL: https://github.com/apache/doris/pull/50714#discussion_r2079682987
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -2794,15 +2795,42 @@ public TGetBinlogResult getBinlog(TGetBinlogRequest
request) throws TException {
TStatus status = new TStatus(TStatusCode.OK);
result.setStatus(status);
+ boolean syncJournal = false;
if (!Env.getCurrentEnv().isMaster()) {
- status.setStatusCode(TStatusCode.NOT_MASTER);
- status.addToErrorMsgs(NOT_MASTER_ERR_MSG);
- result.setMasterAddress(getMasterAddress());
- LOG.error("failed to get beginTxn: {}", NOT_MASTER_ERR_MSG);
- return result;
+ if (request.isAllowFollowerRead()) {
Review Comment:
The condition is reversed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
